🦋 Changeset detected

Latest commit: 439acdc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8115729272/npm-package-wrangler-5135

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5135/npm-package-wrangler-5135

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8115729272/npm-package-wrangler-5135 dev path/to/script.js

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8115729272/npm-package-create-cloudflare-5135 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8115729272/npm-package-cloudflare-kv-asset-handler-5135

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8115729272/npm-package-miniflare-5135

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8115729272/npm-package-cloudflare-pages-shared-5135

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8115729272/npm-package-cloudflare-vitest-pool-workers-5135

wrangler@3.30.1 includes the following runtime dependencies:

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.37%. Comparing base (9d1d11c) to head (439acdc).

@@            Coverage Diff             @@
##             main    #5135      +/-   ##
==========================================
+ Coverage   70.32%   70.37%   +0.04%     
==========================================
  Files         298      298              
  Lines       15542    15542              
  Branches     3999     3999              
==========================================
+ Hits        10930    10937       +7     
+ Misses       4612     4605       -7     

There was a failure for Solid on npm in ubuntu. The logs looked like it had this:

ERROR 1 error(s) and 0 warning(s) when compiling Worker.

  ERROR "cloudflarePages" is not declared in this file

    _worker.js/index.js:1:84368:
    1 │ ...hould be provided by compiler");export{�cloudflarePages� as default};
                                           �    ~~~~~~~~~~~~~~~

I note that there is an upcoming bump of create-solid to 0.5.2? #5098

@petebacondarwin thanks a bunch 🙂👍 I've cherry-picked the dependabot PR's commits here, maybe they can even solve the issue at hand 🤞 📿 🙏

@petebacondarwin thanks a bunch 🙂👍 I've cherry-picked the dependabot PR's commits here, maybe they can even solve the issue at hand 🤞 📿 🙏

nope, no luck 🥲

I've actually jumped the gun there 😓

bumping the solid CLI makes the C3 flow different, I feel like it's not worth it to try to solve everything all at once here, so I've reverted back my previous changes

Note: Solid with npm just doesn't seem to work anymore: solidjs/solid-start#1357 , so we'll have to disable the npm C3 e2e here I think

I'm merging this PR since the e2e failures are all regarding hono and not related to these changes (and as you can see also unrelated PRs get the same failures: https://github.com/cloudflare/workers-sdk/actions/runs/8138824477/job/22240512824?pr=5140)

Hopefully that is fine (I just wanted to get this out of the way and address hono separately)